Re: Bootstrap failures due to C++ warnings with --enable-g…

On Thu, 3 Jul 2008, Kaveh R. GHAZI wrote:

> On Thu, 3 Jul 2008, Diego Novillo wrote:
>
> > > Can you suggest a few things to try? E.g. I did --with-gc=zone and a
> > > couple of errors cropped up. If there are other configurations that come
> > > to mind, let me know.
> >
> > I had these in mind:
> >
> > --disable-checking
> > --enable-checking=all,valgrind (you got time to go on holiday with this one)
> > --enable-coverage
> > Diego.
>
> I tried --disable-checking and --enable-coverage, no problems bootstrap
> completed. Using --with-gc=zone had some warnings which are fixed below.
> I'll try extra --enable-checking options overnight.

So I tried --enable-checking=all,valgrind and it died in stage2 running
genautomata. Plus it took a hideously long time even on an 8x cpu box
just to get that far.

Then I tried a --disable-bootstrap configuration using a regular recent
mainline build in CC just to see the warnings. That died in the same
place. When I switched to gcc-4.3 in CC then I could at least make the
entire directory once to see the warnings. There was only one additional
warning in this configuration.

Tested via "make gcc.o" on x86_64-unknown-linux-gnu configured with
--disable-bootstrap --enable-checking=all,valgrind. The one warning was
eliminated.

Okay for mainline?

        Thanks,
        --Kaveh

2008-07-07 Kaveh R. Ghazi <ghazi@???>

    * gcc.c (execute): Fix -Wc++-compat warning.

--- orig/egcc-SVN20080706/gcc/gcc.c    2008-06-27 18:58:34.000000000 +0200
+++ egcc-SVN20080704/gcc/gcc.c    2008-07-06 08:43:30.000000000 +0200
@@ -2973,7 +2973,7 @@ execute (void)
for (argc = 0; commands[i].argv[argc] != NULL; argc++)
    ;

- argv = alloca ((argc + 3) * sizeof (char *));
+ argv = XALLOCAVEC (const char *, argc + 3);

argv[0] = VALGRIND_PATH;
argv[1] = "-q";