Takashi Sato wrote:
>
> ftp_commands.c: In function 'ftp_cmd_pbsz':
> ftp_commands.c:1706: warning: comparison is always false due to limited range of data type
>
> If 'arg' is "2147483647"
> on the sizeof(int) == 4 == sizeof(long) system,
> fc->pbsz == LONG_MAX.
> But on the sizeof(int) == 4 < sizeof(long) system,
> fc->pbsz != LONG_MAX.
>
> I have not read the code deeply, but I think this is not quite dangerous.
> There is no code using pbsz.
> I have found other assignments of resutl of strtol to int.
>
> mod_ftp.c line 406
> *(int *) ((char *) fsc + offset) = strtol(arg, &endptr, 10);
> line 436
> umask = strtol(arg, &endp, 8);
> line 459
> umask = strtol(arg, &endp, 8);
>
> My environment:
> FreeBSD 7-STABLE AMD64
> gcc version 4.2.1 20070719 [FreeBSD]
All good bugs to fix, thanks Takashi. None look like showstoppers to an
alpha quality release though ;-)
Bill
